AbstractFunctionParameter sniffs: add tests for namespaced names #2633
+234
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Moved to draft pending the review of #2620 |
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
from
fbcdd23 to
1b63aec
Compare
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
from
1b63aec to
6040916
Compare
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
from
6040916 to
2db68b0
Compare
Doing this to allow for additional testcase files.
I'm adding three different tests for fully qualified global function calls to cover all the global functions that are referenced directly in the `I18nSniff::process_matched_token()` method.
rodrigoprimo
force-pushed
the
abstract-function-parameter-sniffs-tests
branch
from
2db68b0 to
d476988
Compare
Collaborator
Author
|
@jrfnl, since another PR was reviewed earlier today, I'm marking this one as ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for PHPCS 4.0, which changes the tokenization of namespaced names, this PR adds tests with all forms of namespaced function calls (partially qualified, fully qualified, and namespace-relative using the 'namespace' keyword) as well as fully qualified global function calls to the sniffs that extend the
AbstractFunctionParameterSniffclass when necessary. Some test files already contained part or all of the required tests.Tests for
WordPress.WP.EnqueuedResourceParametersare not included in this PR as they would conflict with #2630. I will add tests for this sniff in a separate PR once #2630 is merged.In some cases, it was necessary to move syntax error tests to a separate file before adding the new tests.
Suggested changelog entry
N/A